Attention is currently required from: Martin Roth, Angel Pons, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49673 )
Change subject: soc/intel/block/cpu: Add function configure the CPU DEBUG interface ......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/common/block/cpu/cpu_debug.c:
https://review.coreboot.org/c/coreboot/+/49673/comment/54defbec_c0a452d4 PS2, Line 33: !debug_interface_enabled();
Why not pass and use `bool enable` here?
Right. it already depends on the caller checking the lock bit, so it could also just assume that one is actually doing something usefull when calling instead of reading the register again.
File src/soc/intel/common/block/include/intelblocks/cpu_debug.h:
https://review.coreboot.org/c/coreboot/+/49673/comment/eacb7df7_d714f493 PS2, Line 8: all APs
On all sockets as well?
No idea, the documentation does not say if those are shared or not. I try to test this.