Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35675 )
Change subject: intel/i945: Define p2peg for PCIe x16 slot
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35675/1/src/northbridge/intel/i945/...
File src/northbridge/intel/i945/early_init.c:
https://review.coreboot.org/c/coreboot/+/35675/1/src/northbridge/intel/i945/...
PS1, Line 532: pci_devfn_t
const?
Could be but, but hopefully is not required by style guide.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35675
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e9dd06376c1076be4a4c41ff87dfd3cf820d7bc
Gerrit-Change-Number: 35675
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 29 Sep 2019 07:19:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment