Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40581 )
Change subject: mb/clevo/n141cu: Add new Comet Lake mainboard ......................................................................
Patch Set 34:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40581/30/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/40581/30/src/mainboard/clevo/cml-u/... PS30, Line 15: MAINBOARD_HAS_LPC_TPM
u sure? according to datasheet it's spi
Done
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... PS31, Line 18: select ONBOARD_VGA_IS_PRIMARY
As far as I understand the code, this configures the iGPU as the default graphics controller.
Done
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/romstage.c:
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... PS31, Line 22: 0
Any reason to disable ECT?
Done
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/variants/n141cu/include/gpio_table.h:
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... PS31, Line 91: 0x04000201
this will trigger an error "gpio_pad_reset_config_override: Logical to Chipset mapping not found" du […]
Done