Change in coreboot[master]: HACK: skip reading EDID completely

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: WIP:...

yongqiang niu (Code Review)

20 Oct 2020 20 Oct '20

12:54 a.m.

Hello Nicolas Boichat,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/46580

to review the following change.

Change subject: HACK: skip reading EDID completely ......................................................................

HACK: skip reading EDID completely

Something goes terribly wrong when reading the EDID, and ANX7625 does not seem to be able to recover from it.

BUG=b:155713214 TEST=boot asurada

Change-Id: I2230af30b709667f9858f6144b14681686003f28 --- M src/drivers/analogix/anx7625/anx7625.c 1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/46580/1

diff --git a/src/drivers/analogix/anx7625/anx7625.c b/src/drivers/analogix/anx7625/anx7625.c index eb7e661..e3f969c 100644 --- a/src/drivers/analogix/anx7625/anx7625.c +++ b/src/drivers/analogix/anx7625/anx7625.c @@ -854,7 +854,9 @@ int ret; u8 edid[FOUR_BLOCK_SIZE];

- block_num = sp_tx_edid_read(bus, edid, FOUR_BLOCK_SIZE); + /* Something goes terribly wrong here, and ANX7625 does not seem to be able to recover from it. */ + if (0) + block_num = sp_tx_edid_read(bus, edid, FOUR_BLOCK_SIZE); block_num=1;

memcpy(edid, &edp_edid, sizeof(edp_edid));

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

build bot (Jenkins) (Code Review)

20 Oct 20 Oct

12:55 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46580 )

Change subject: HACK: skip reading EDID completely ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46580/1/src/drivers/analogix/anx762... File src/drivers/analogix/anx7625/anx7625.c:

https://review.coreboot.org/c/coreboot/+/46580/1/src/drivers/analogix/anx762... PS1, Line 857: /* Something goes terribly wrong here, and ANX7625 does not seem to be able to recover from it. */ line over 96 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/46580 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2230af30b709667f9858f6144b14681686003f28 Gerrit-Change-Number: 46580 Gerrit-PatchSet: 1 Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com Gerrit-Reviewer: Nicolas Boichat drinkcat@chromium.org Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 20 Oct 2020 07:55:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

11:35 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46580 )

Change subject: HACK: skip reading EDID completely ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46580/2/src/drivers/analogix/anx762... File src/drivers/analogix/anx7625/anx7625.c:

https://review.coreboot.org/c/coreboot/+/46580/2/src/drivers/analogix/anx762... PS2, Line 857: /* Something goes terribly wrong here, and ANX7625 does not seem to be able to recover from it. */ line over 96 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/46580 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2230af30b709667f9858f6144b14681686003f28 Gerrit-Change-Number: 46580 Gerrit-PatchSet: 2 Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com Gerrit-Reviewer: Nicolas Boichat drinkcat@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 21 Oct 2020 06:35:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

26 Oct 26 Oct

2:33 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46580 )

Change subject: HACK: skip reading EDID completely ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46580/3/src/drivers/analogix/anx762... File src/drivers/analogix/anx7625/anx7625.c:

https://review.coreboot.org/c/coreboot/+/46580/3/src/drivers/analogix/anx762... PS3, Line 857: /* Something goes terribly wrong here, and ANX7625 does not seem to be able to recover from it. */ line over 96 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/46580 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2230af30b709667f9858f6144b14681686003f28 Gerrit-Change-Number: 46580 Gerrit-PatchSet: 3 Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com Gerrit-Reviewer: Nicolas Boichat drinkcat@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 26 Oct 2020 09:33:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

10 Nov 10 Nov

1:31 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46580 )

Change subject: HACK: skip reading EDID completely ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46580/4/src/drivers/analogix/anx762... File src/drivers/analogix/anx7625/anx7625.c:

https://review.coreboot.org/c/coreboot/+/46580/4/src/drivers/analogix/anx762... PS4, Line 857: /* Something goes terribly wrong here, and ANX7625 does not seem to be able to recover from it. */ line over 96 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/46580 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2230af30b709667f9858f6144b14681686003f28 Gerrit-Change-Number: 46580 Gerrit-PatchSet: 4 Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com Gerrit-Reviewer: Jg Daolongzhu jg_daolongzhu@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 10 Nov 2020 09:31:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

11 Nov 11 Nov

7:57 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46580 )

Change subject: HACK: skip reading EDID completely ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46580/5/src/drivers/analogix/anx762... File src/drivers/analogix/anx7625/anx7625.c:

https://review.coreboot.org/c/coreboot/+/46580/5/src/drivers/analogix/anx762... PS5, Line 857: /* Something goes terribly wrong here, and ANX7625 does not seem to be able to recover from it. */ line over 96 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/46580 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2230af30b709667f9858f6144b14681686003f28 Gerrit-Change-Number: 46580 Gerrit-PatchSet: 5 Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com Gerrit-Reviewer: Jg Daolongzhu jg_daolongzhu@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 12 Nov 2020 03:57:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yongqiang Niu (Code Review)

10:38 p.m.

Yongqiang Niu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46580 )

Change subject: HACK: skip reading EDID completely ......................................................................

Patch Set 5:

abandon

fix with https://review.coreboot.org/c/coreboot/+/47392/

-- To view, visit https://review.coreboot.org/c/coreboot/+/46580 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2230af30b709667f9858f6144b14681686003f28 Gerrit-Change-Number: 46580 Gerrit-PatchSet: 5 Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com Gerrit-Reviewer: Jg Daolongzhu jg_daolongzhu@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yongqiang Niu yongqiang.niu@mediatek.corp-partner.google.com Gerrit-Comment-Date: Thu, 12 Nov 2020 06:38:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

yongqiang niu (Code Review)

17 Nov 17 Nov

12:31 a.m.

yongqiang niu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46580 )

Change subject: HACK: skip reading EDID completely ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/46580 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2230af30b709667f9858f6144b14681686003f28 Gerrit-Change-Number: 46580 Gerrit-PatchSet: 5 Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com Gerrit-Reviewer: Jg Daolongzhu jg_daolongzhu@mediatek.corp-partner.google.com Gerrit-Reviewer: Nicolas Boichat drinkcat@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yongqiang Niu yongqiang.niu@mediatek.corp-partner.google.com Gerrit-MessageType: abandon

1464

days inactive

1492

days old

coreboot-gerrit@coreboot.org

7 comments

3 participants

tags (0)

participants (3)

build bot (Jenkins) (Code Review)
Yongqiang Niu (Code Review)
yongqiang niu (Code Review)