Attention is currently required from: Bao Zheng, Martin Roth, Marshall Dawson, Kangheui Won, Paul Menzel, Zheng Bao, Karthikeyan Ramasubramanian, Felix Held.
Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56438 )
Change subject: [WIP]amdfwtool: Use relative address for EFS gen2
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56438/comment/b408b451_b7963e28
PS2, Line 9: The second generation EFS (offset 0x24[0]=0) uses
: "binary relative" offsets and not "x86 physical
: MMIO address" like gen1.
:
: Chips like Cezanne can run in both cases, so no problem
: comes up so far.
:
: TODO: Need to fix the problem in psp_verstage.
Please re-flow for 75 characters per line.
if this breaks psp_verstage, why are you putting it up for review?
https://review.coreboot.org/c/coreboot/+/56438/comment/d306e6dc_09089faa
PS2, Line 19: Test=Majolica (Cezanne)
need to test on guybrush as well since Majolica doesn't have the TPM that guybrush does.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56438
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7701c7819f03586d4ecab3d744056c8c902b630f
Gerrit-Change-Number: 56438
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 20 Aug 2021 22:07:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment