Change in ...coreboot[master]: commonlib/bubblesort: Do not try to sort less than two entries

[Werner Zeh (Code Review)]

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31854

Change subject: commonlib/bubblesort: Do not try to sort less than two entries
......................................................................

commonlib/bubblesort: Do not try to sort less than two entries

Before start sorting check for the number of entries in the data set. If
there are less than two entries, sorting makes no sense.

Change-Id: Ib9d5522cdebb6559a025217f7faf318589d55a2c
Signed-off-by: Werner Zeh 
---
M src/commonlib/sort.c
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/31854/1

diff --git a/src/commonlib/sort.c b/src/commonlib/sort.c
index 4099939..350138e 100644
--- a/src/commonlib/sort.c
+++ b/src/commonlib/sort.c
@@ -23,6 +23,10 @@
    size_t i, j;
    int swapped;

+	/* Make sure there are at least two entries to sort. */
+	if (num_entries < 2)
+		return;
+
    for (j = 0; j < num_entries - 1; j++) {
    	swapped = 0;
    	for (i = 0; i < num_entries - j - 1; i++) {

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31854 )

Change subject: commonlib/bubblesort: Do not try to sort less than two entries
......................................................................

Patch Set 1: Code-Review+2

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31854 )

Change subject: commonlib/bubblesort: Do not try to sort less than two entries
......................................................................

Patch Set 1: Code-Review+2

[Werner Zeh (Code Review)]

Werner Zeh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31854 )

Change subject: commonlib/bubblesort: Do not try to sort less than two entries
......................................................................

commonlib/bubblesort: Do not try to sort less than two entries

Before start sorting check for the number of entries in the data set. If
there are less than two entries, sorting makes no sense.

Change-Id: Ib9d5522cdebb6559a025217f7faf318589d55a2c
Signed-off-by: Werner Zeh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31854
Tested-by: build bot (Jenkins) 
Reviewed-by: Kyösti Mälkki 
Reviewed-by: Arthur Heymans 
---
M src/commonlib/sort.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved
  Arthur Heymans: Looks good to me, approved

diff --git a/src/commonlib/sort.c b/src/commonlib/sort.c
index 4099939..350138e 100644
--- a/src/commonlib/sort.c
+++ b/src/commonlib/sort.c
@@ -23,6 +23,10 @@
    size_t i, j;
    int swapped;

+	/* Make sure there are at least two entries to sort. */
+	if (num_entries < 2)
+		return;
+
    for (j = 0; j < num_entries - 1; j++) {
    	swapped = 0;
    	for (i = 0; i < num_entries - j - 1; i++) {