Change in coreboot[master]: mb/purism/librem_cnl: Implement `die_notify` - coreboot-gerrit

4 Feb 2021


      Attention is currently required from: Martin Roth, Matt DeVillier.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50013 )
Change subject: mb/purism/librem_cnl: Implement `die_notify`
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
...
tested ok on a Librem Mini v2, but as-is requires all future variants (like the upcoming Librem 14)  […]
Hmmm... Good point. I could try using a `wildcard` (optionally adds a file to be built), or move die.c out of variants and define the LED GPIO in a per-variant header.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50013
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ffac0ab02e52e9fbba7990f401d87e50a1b5154
Gerrit-Change-Number: 50013
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Comment-Date: Thu, 04 Feb 2021 09:54:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com
Gerrit-MessageType: comment