Attention is currently required from: Alicja Michalska, Benjamin Doron, David Milosevic, Felix Held, Felix Singer, Lean Sheng Tan, Matt DeVillier.
Angel Pons has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )
Change subject: mb/hardkernel/odroid-h4: Add support for ODROID-H4 series ......................................................................
Patch Set 10:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83979/comment/df66d883_0e3a8618?usp... : PS10, Line 22: - S3 suspend/resume Windows 10 BSODs after resuming with `TDR_RECOVERY_FAILURE`, no idea why though.
Windows itself works fine, though. So does Arch Linux (booted from SATA).
https://review.coreboot.org/c/coreboot/+/83979/comment/9742bd03_3651ae0b?usp... : PS10, Line 27: - Dual BIOS: flash chip switching mechanism is very sus I was told this is broken on the board I'm testing with, so it's not a coreboot issue.
https://review.coreboot.org/c/coreboot/+/83979/comment/5c3328cc_487b434a?usp... : PS10, Line 32: - Fan control: seems wonky because of onboard temp sensor Might need to adjust thresholds but should work with the thermal resistor (PECI doesn't work)
https://review.coreboot.org/c/coreboot/+/83979/comment/b8f36a17_c6e3e77d?usp... : PS10, Line 33: - Rest of Super I/O config: needs exorcism Seems fine
https://review.coreboot.org/c/coreboot/+/83979/comment/50b0a5e1_122d3c37?usp... : PS10, Line 35: - M.2 slot (PCIe only, no SATA lanes) Tested and working
https://review.coreboot.org/c/coreboot/+/83979/comment/605a46ba_18b1382b?usp... : PS10, Line 36: - Windows (with edk2 payload) Tested and working
https://review.coreboot.org/c/coreboot/+/83979/comment/a6599183_8a09a1f5?usp... : PS10, Line 37: - PCIe ASPM and friends PCIe devices seem fine