Attention is currently required from: Lean Sheng Tan, Werner Zeh.
Mario Scheithauer has posted comments on this change by Mario Scheithauer. ( https://review.coreboot.org/c/coreboot/+/84399?usp=email )
Change subject: soc/intel/ehl/fsp_params: Fix double setting of 'PchPwrOptEnable'
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/elkhartlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/84399/comment/7310ebcf_09ab3580?usp... :
PS2, Line 327: params->PchPwrOptEnable = 0;
I would keep this line just to be independent from the default FSP setting.
Yes, you're right. It also looks better.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84399?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f31015c1da51a4ae1b8d5226f5d7b60a6023f3d
Gerrit-Change-Number: 84399
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 17 Sep 2024 16:43:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com