Change in ...coreboot[master]: src/drivers/intel/wifi/Kconfig: enable NO_INTEL_WIFI if !SYSTEM_TYPE_...
Hello Mike Banon,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31220
to review the following change.
Change subject: src/drivers/intel/wifi/Kconfig: enable NO_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP ......................................................................
src/drivers/intel/wifi/Kconfig: enable NO_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP
Intel PCI-e WiFi adapters are rare outside of laptops. DRIVERS_INTEL_WIFI should not be selected by default if the mainboard is not a laptop.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I93a9e8fc9ba92f755524250e6cbcf9d1ba1acbdc --- M src/drivers/intel/wifi/Kconfig 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/31220/1
diff --git a/src/drivers/intel/wifi/Kconfig b/src/drivers/intel/wifi/Kconfig index 4082d7e..8fdd0a3 100644 --- a/src/drivers/intel/wifi/Kconfig +++ b/src/drivers/intel/wifi/Kconfig @@ -8,7 +8,9 @@
# Select this for mainboard which is unlikely to have Intel PCI-e WiFi adapter. config NO_INTEL_WIFI - def_bool n + bool + default y if !SYSTEM_TYPE_LAPTOP + default n
config USE_SAR bool
mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31220 )
Change subject: src/drivers/intel/wifi/Kconfig: enable NO_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP ......................................................................
Patch Set 1:
This change depends on CB:31119 - src/drivers/intel/wifi/Kconfig: add NO_INTEL_WIFI option
mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31220 )
Change subject: src/drivers/intel/wifi/Kconfig: enable NO_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP ......................................................................
Patch Set 1:
Patch Set 1:
This change depends on CB:31119 - src/drivers/intel/wifi/Kconfig: add NO_INTEL_WIFI option
Sorry I meant CB:31219 - src/drivers/intel/wifi/Kconfig: add NO_INTEL_WIFI option
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31220 )
Change subject: src/drivers/intel/wifi/Kconfig: enable NO_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP ......................................................................
Patch Set 1: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31220 )
Change subject: src/drivers/intel/wifi/Kconfig: enable NO_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP ......................................................................
Patch Set 1:
(1 comment)
This will become a little more complicated, see CB:31206.
https://review.coreboot.org/#/c/31220/1/src/drivers/intel/wifi/Kconfig File src/drivers/intel/wifi/Kconfig:
https://review.coreboot.org/#/c/31220/1/src/drivers/intel/wifi/Kconfig@12 PS1, Line 12: default y if !SYSTEM_TYPE_LAPTOP As `NO_INTEL_WIFI` only changes the default above, I'd rather see this directly in DRIVERS_INTEL_WIFI's default line.
Hello Patrick Rudolph, HAOUAS Elyes, Mike Banon, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31220
to look at the new patch set (#2).
Change subject: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP ......................................................................
drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP
Intel PCI-e WiFi adapters are rare outside of laptops. DRIVERS_INTEL_WIFI should not be selected by default if the mainboard is not a laptop.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I93a9e8fc9ba92f755524250e6cbcf9d1ba1acbdc --- M src/drivers/intel/wifi/Kconfig 1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/31220/2
mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31220 )
Change subject: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31220/1/src/drivers/intel/wifi/Kconfig File src/drivers/intel/wifi/Kconfig:
https://review.coreboot.org/#/c/31220/1/src/drivers/intel/wifi/Kconfig@12 PS1, Line 12: default y if !SYSTEM_TYPE_LAPTOP
As `NO_INTEL_WIFI` only changes the default above, I'd rather […]
Great idea! Although I couldn't resolve a merge conflict so I abandoned this change and made a new one, CB:31222 , please take a look
mikeb mikeb has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31220 )
Change subject: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP ......................................................................
Abandoned
moving to CB:31222
-
HAOUAS Elyes (Code Review) -
mikeb mikeb (Code Review)
-
Nico Huber (Code Review)