Change in coreboot[master]: cpu/intel/haswell/haswell_init.c: Align printk's with Broadwell

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

25 Sep 2020 25 Sep '20

9:17 a.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45722 )

Change subject: cpu/intel/haswell/haswell_init.c: Align printk's with Broadwell ......................................................................

cpu/intel/haswell/haswell_init.c: Align printk's with Broadwell

Change-Id: I09f4fc5af28b20663b87d18852d585121feaab09 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/intel/haswell/haswell_init.c 1 file changed, 2 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/45722/1

diff --git a/src/cpu/intel/haswell/haswell_init.c b/src/cpu/intel/haswell/haswell_init.c index 5f3debb..ca2e89d 100644 --- a/src/cpu/intel/haswell/haswell_init.c +++ b/src/cpu/intel/haswell/haswell_init.c @@ -618,7 +618,7 @@ } wrmsr(IA32_PERF_CTL, perf_ctl);

- printk(BIOS_DEBUG, "haswell: frequency set to %d\n", + printk(BIOS_DEBUG, "cpu: frequency set to %d\n", ((perf_ctl.lo >> 8) & 0xff) * HASWELL_BCLK); }

@@ -638,8 +638,7 @@ msr.lo |= policy & 0xf; wrmsr(IA32_ENERGY_PERF_BIAS, msr);

- printk(BIOS_DEBUG, "haswell: energy policy set to %u\n", - policy); + printk(BIOS_DEBUG, "cpu: energy policy set to %u\n", policy); }

static void configure_mca(void)

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

HAOUAS Elyes (Code Review)

25 Sep 25 Sep

5:47 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45722 )

Change subject: cpu/intel/haswell/haswell_init.c: Align printk's with Broadwell ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45722/1/src/cpu/intel/haswell/haswe... File src/cpu/intel/haswell/haswell_init.c:

https://review.coreboot.org/c/coreboot/+/45722/1/src/cpu/intel/haswell/haswe... PS1, Line 621: cpu CPU

-- To view, visit https://review.coreboot.org/c/coreboot/+/45722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09f4fc5af28b20663b87d18852d585121feaab09 Gerrit-Change-Number: 45722 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 25 Sep 2020 07:47:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

5:57 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45722 )

Change subject: cpu/intel/haswell/haswell_init.c: Align printk's with Broadwell ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45722/1/src/cpu/intel/haswell/haswe... File src/cpu/intel/haswell/haswell_init.c:

https://review.coreboot.org/c/coreboot/+/45722/1/src/cpu/intel/haswell/haswe... PS1, Line 621: cpu

...

CPU

Broadwell uses `cpu` too. Let me pull yet aaaaanother patch to change that

-- To view, visit https://review.coreboot.org/c/coreboot/+/45722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09f4fc5af28b20663b87d18852d585121feaab09 Gerrit-Change-Number: 45722 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 25 Sep 2020 07:57:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

6:03 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45722 )

Change subject: cpu/intel/haswell/haswell_init.c: Align printk's with Broadwell ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45722/1/src/cpu/intel/haswell/haswe... File src/cpu/intel/haswell/haswell_init.c:

https://review.coreboot.org/c/coreboot/+/45722/1/src/cpu/intel/haswell/haswe... PS1, Line 621: cpu

...

Broadwell uses `cpu` too. […]

change it as well inhere ... :) I mean both files :p

-- To view, visit https://review.coreboot.org/c/coreboot/+/45722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09f4fc5af28b20663b87d18852d585121feaab09 Gerrit-Change-Number: 45722 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 25 Sep 2020 08:03:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Angel Pons (Code Review)

6:06 p.m.

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45722

to look at the new patch set (#2).

Change subject: cpu/intel/haswell/haswell_init.c: Align printk's with Broadwell ......................................................................

cpu/intel/haswell/haswell_init.c: Align printk's with Broadwell

Change-Id: I09f4fc5af28b20663b87d18852d585121feaab09 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/intel/haswell/haswell_init.c 1 file changed, 2 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/45722/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09f4fc5af28b20663b87d18852d585121feaab09 Gerrit-Change-Number: 45722 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

6:06 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45722 )

Change subject: cpu/intel/haswell/haswell_init.c: Align printk's with Broadwell ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45722/1/src/cpu/intel/haswell/haswe... File src/cpu/intel/haswell/haswell_init.c:

https://review.coreboot.org/c/coreboot/+/45722/1/src/cpu/intel/haswell/haswe... PS1, Line 621: cpu

...

Broadwell uses `cpu` too. […]

CB:45728

-- To view, visit https://review.coreboot.org/c/coreboot/+/45722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09f4fc5af28b20663b87d18852d585121feaab09 Gerrit-Change-Number: 45722 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 25 Sep 2020 08:06:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:49 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45722 )

Change subject: cpu/intel/haswell/haswell_init.c: Align printk's with Broadwell ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09f4fc5af28b20663b87d18852d585121feaab09 Gerrit-Change-Number: 45722 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 25 Sep 2020 09:49:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

28 Sep 28 Sep

8:45 a.m.

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45722 )

Change subject: cpu/intel/haswell/haswell_init.c: Align printk's with Broadwell ......................................................................

cpu/intel/haswell/haswell_init.c: Align printk's with Broadwell

Change-Id: I09f4fc5af28b20663b87d18852d585121feaab09 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45722 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/cpu/intel/haswell/haswell_init.c 1 file changed, 2 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved

diff --git a/src/cpu/intel/haswell/haswell_init.c b/src/cpu/intel/haswell/haswell_init.c index 5f3debb..ac5dec6 100644 --- a/src/cpu/intel/haswell/haswell_init.c +++ b/src/cpu/intel/haswell/haswell_init.c @@ -618,7 +618,7 @@ } wrmsr(IA32_PERF_CTL, perf_ctl);

- printk(BIOS_DEBUG, "haswell: frequency set to %d\n", + printk(BIOS_DEBUG, "CPU: frequency set to %d\n", ((perf_ctl.lo >> 8) & 0xff) * HASWELL_BCLK); }

@@ -638,8 +638,7 @@ msr.lo |= policy & 0xf; wrmsr(IA32_ENERGY_PERF_BIAS, msr);

- printk(BIOS_DEBUG, "haswell: energy policy set to %u\n", - policy); + printk(BIOS_DEBUG, "CPU: energy policy set to %u\n", policy); }

static void configure_mca(void)

-- To view, visit https://review.coreboot.org/c/coreboot/+/45722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09f4fc5af28b20663b87d18852d585121feaab09 Gerrit-Change-Number: 45722 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1472

days inactive

1475

days old

coreboot-gerrit@coreboot.org

7 comments

2 participants

tags (0)

participants (2)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)