Attention is currently required from: Subrata Banik, Selma Bensaid, Paul Menzel, Julius Werner, Patrick Rudolph. Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59507 )
Change subject: soc/intel/alderlake: Inject CSE TS into CBMEM timestamp table ......................................................................
Patch Set 14:
(13 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59507/comment/efd8f81f_ba61e6dc PS12, Line 7: timestamp_table
CBMEM timestamp table
Done
https://review.coreboot.org/c/coreboot/+/59507/comment/96bc6841_0012a747 PS12, Line 9: it
them
Done
https://review.coreboot.org/c/coreboot/+/59507/comment/33127959_3892a01e PS12, Line 11:
Please mention, that they need to be normalized?
Done
https://review.coreboot.org/c/coreboot/+/59507/comment/e39afb62_83f8cfbe PS12, Line 13: TEST=Able to see TS elapse prior to IA reset.
Please mention the board, and even paste the new output.
Done
File src/soc/intel/common/block/cse/telemetry.c:
https://review.coreboot.org/c/coreboot/+/59507/comment/b73cf13c_5cc4aa7a PS7, Line 72: BS_PRE_DEVICE
Thanks Subrata for raising good points. […]
Done
File src/soc/intel/common/block/cse/telemetry.c:
https://review.coreboot.org/c/coreboot/+/59507/comment/a1c4bd2c_2c2ed403 PS12, Line 33: int
`unsigned int` or `size_t`
Done
https://review.coreboot.org/c/coreboot/+/59507/comment/e33d7207_e8382a7d PS12, Line 35: 0xFFFFFFFF
Please use lowercase.
Done
https://review.coreboot.org/c/coreboot/+/59507/comment/e7d8fb40_29c3b32d PS12, Line 36: printk(BIOS_ERR, "%s: CSME timestamps invalid\n", __func__);
What should the user do in such a case?
no action needed from the user. Just to explain why they are not seeing CSE timestamps in the cbmem timstamp table.
https://review.coreboot.org/c/coreboot/+/59507/comment/b15ea153_5e5f4d54 PS12, Line 45: int
Ditto.
Done
https://review.coreboot.org/c/coreboot/+/59507/comment/927146cc_129c4780 PS12, Line 53: int
Ditto.
Done
https://review.coreboot.org/c/coreboot/+/59507/comment/fba78e12_c6c54af1 PS12, Line 53: zero_point_idx+1
Please add spaces around operators.
Done
https://review.coreboot.org/c/coreboot/+/59507/comment/90a8f9a4_bfb630cc PS12, Line 56: printk(BIOS_ERR, "%s: CSME timestamps invalid\n", __func__);
- Print the value both values? […]
1. I think it is not useful to print the values in this case. But I added an indication for the user that wrap-around was detected. 2. just to explain why they don't see CSE timestamps in their cbmem timestamp table.
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/59507/comment/e1d6761d_f18369c5 PS12, Line 502: coreboot
CBMEM
Done