Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, ritul guru.
Martin Roth has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/83740?usp=email )
Change subject: soc/amd/common/psp_smi: implement P2C mailbox handling
......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
Since this is a software feature and not actually about the PSP, shouldn't this go someplace other than amd/common/block/psp?
File src/soc/amd/common/block/psp/psp_smi.c:
https://review.coreboot.org/c/coreboot/+/83740/comment/67dd40a3_5b773cfe?usp... :
PS4, Line 33: tmp
Nit: I know that the union is already named status, but why tmp and not something like 'status'? I mean, all variables are temporary.
Same below.
https://review.coreboot.org/c/coreboot/+/83740/comment/c4c3b3de_62b5e3d3?usp... :
PS4, Line 80: u32
Nit: this seems to use a mix of u8/u32 and uint8_t/uint32_t. Can we standardize on one?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83740?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I50479bed2332addae652026c6818460eeb6403af
Gerrit-Change-Number: 83740
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 06 Aug 2024 15:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No