Attention is currently required from: Mike Banon, Idwer Vollering, Angel Pons, Arthur Heymans, Kyösti Mälkki, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53982 )
Change subject: AGESA f15tn boards: Sync IDS option values
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/53982/comment/b67801ee_05cd28e4
PS6, Line 14: Note that the `IDSOPT_TRACING_ENABLED` option currently fails to build.
But as `src/mainboard/asus/a88xm-e/OptionsIds.h` did not define `IDSOPT_IDS_ENABLED` it wasn’t noticed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53982
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iedd4d1f255650012f3efd9a27718e18c1c904dc1
Gerrit-Change-Number: 53982
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Mike Banon
mikebdp2@gmail.com
Gerrit-Attention: Idwer Vollering
vidwer@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Mike Banon
mikebdp2@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 22 Aug 2021 10:31:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment