Attention is currently required from: Diana Zigterman, Kenneth Chan, Karthik Ramasubramanian.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63649 )
Change subject: mb/google/guybrush: Enable tablet mode switch
......................................................................
Patch Set 3: -Code-Review
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/63649/comment/67d14853_bb47f791
PS3, Line 65: #define EC_ENABLE_TBMC_DEVICE
This should be moved to dewatt/include/variant/ec.h
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63649
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ae31f314ee42474a1252be458ab383ec6036d85
Gerrit-Change-Number: 63649
Gerrit-PatchSet: 3
Gerrit-Owner: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Diana Zigterman
dzigterman@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Diana Zigterman
dzigterman@google.com
Gerrit-Attention: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 15 Apr 2022 15:55:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment