Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Varshit Pandya.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81626?usp=email )
Change subject: mb/google/brya: Add new baseboard trulo
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/trulo/gpio.c:
https://review.coreboot.org/c/coreboot/+/81626/comment/f675b5b4_30a70084 :
PS6, Line 42: const struct cros_gpio *__weak variant_cros_gpios(size_t *num)
: {
: *num = ARRAY_SIZE(cros_gpios);
: return cros_gpios;
: }
this and DECLARE_CROS_GPIOS(cros_gpios); both same. u will run into definition error
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81626?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iad6230064c6b8359698d37c3e0440614cc7b073d
Gerrit-Change-Number: 81626
Gerrit-PatchSet: 6
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 04 Apr 2024 06:11:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment