Attention is currently required from: Martin L Roth, Nico Huber, Torsten Schenk.
Julius Werner has posted comments on this change by Torsten Schenk. ( https://review.coreboot.org/c/coreboot/+/83379?usp=email )
Change subject: Makefile: unexport CFLAGS ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: Where does the flag leak, exactly? I believe for the actual coreboot cross-compilation, nothing should be using a variable that's just called `CFLAGS` (coreboot is using `CFLAGS_common`, `CFLAGS_ramstage`, etc.). For host utilities like `cbmem` I believe this may be "working as intended" and in line with other Linux utilities that are usually sensitive to these variables to allow the host environment to add custom options if it needs to (although we're not very consistent in that, e.g. `cbfstool` doesn't seem to use it either).
If you don't want things you compile to fail from extra errors, you probably shouldn't have `CFLAGS=-Werror` in your environment.