Attention is currently required from: Tim Wawrzynczak, Robert Chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60331 )
Change subject: mb/google/brya/var/vell: Add AMP driver setting ......................................................................
Patch Set 3: Verified+1
(5 comments)
File src/drivers/i2c/cs35l53/cs35l53.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136293): https://review.coreboot.org/c/coreboot/+/60331/comment/d6ae121e_60219003 PS3, Line 70: if ((config->boost_peak_milliamp > 4500) || that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136293): https://review.coreboot.org/c/coreboot/+/60331/comment/3b67602f_0fba76ab PS3, Line 83: acpi_dp_add_integer(dsd, "cirrus,gpio1-polarity-invert", config->gpio1_polarity_invert ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136293): https://review.coreboot.org/c/coreboot/+/60331/comment/f2b343c4_34a92300 PS3, Line 84: acpi_dp_add_integer(dsd, "cirrus,gpio1-output-enable", config->gpio1_output_enable ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136293): https://review.coreboot.org/c/coreboot/+/60331/comment/45723b02_32c96f5f PS3, Line 86: acpi_dp_add_integer(dsd, "cirrus,gpio2-polarity-invert", config->gpio2_polarity_invert ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136293): https://review.coreboot.org/c/coreboot/+/60331/comment/a679ad6a_a691db45 PS3, Line 87: acpi_dp_add_integer(dsd, "cirrus,gpio2-output-enable", config->gpio2_output_enable ? 1 : 0); line over 96 characters
-
build bot (Jenkins) (Code Review)