Barnali Sarkar has uploaded this change for review. ( https://review.coreboot.org/20088
Change subject: soc/intel/apollolake: Removed duplication of find_microcode_patch() code ......................................................................
soc/intel/apollolake: Removed duplication of find_microcode_patch() code
Since get_microcode_info() is aleady searching for the microcode in cbfs, we can just add a intel_microcode_load_unlocked() call here to update the microcode. No need to duplicate finding microcode step during pre_mp_init() function.
Change-Id: I525cab0ecc7826554f0a1209862e6357d1c7a9a6 Signed-off-by: Barnali Sarkar barnali.sarkar@intel.com --- M src/soc/intel/apollolake/cpu.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/20088/1
diff --git a/src/soc/intel/apollolake/cpu.c b/src/soc/intel/apollolake/cpu.c index ff300bc..b0e2da5 100644 --- a/src/soc/intel/apollolake/cpu.c +++ b/src/soc/intel/apollolake/cpu.c @@ -117,9 +117,6 @@ { x86_setup_mtrrs_with_detect(); x86_mtrr_check(); - - /* Make sure BSP is using the microcode from cbfs */ - intel_update_microcode_from_cbfs(); }
/* Find CPU topology */ @@ -139,6 +136,9 @@ { *microcode = intel_microcode_find(); *parallel = 1; + + /* Make sure BSP is using the microcode from cbfs */ + intel_microcode_load_unlocked(*microcode); }
static void get_smm_info(uintptr_t *perm_smbase, size_t *perm_smsize,