Change in coreboot[master]: mb/google/volteer: add GPP_F11 to baseboard gpio_table.

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Nick Vaccaro (Code Review)

25 Aug 2020 25 Aug '20

1:25 a.m.

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44745 )

Change subject: mb/google/volteer: add GPP_F11 to baseboard gpio_table. ......................................................................

mb/google/volteer: add GPP_F11 to baseboard gpio_table.

GPP_F11 was in the early gpio table, but the definition was missing from the main gpio_table. This change adds GPP_F11 to the gpio_table array.

BUG=none TEST="emerge-volteer coreboot" and verify it builds correctly.

Change-Id: I40f887300a9dfd4f8e790031b77bbee8a014f499 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/44745/1

diff --git a/src/mainboard/google/volteer/variants/baseboard/gpio.c b/src/mainboard/google/volteer/variants/baseboard/gpio.c index ad17a94..c938b28 100644 --- a/src/mainboard/google/volteer/variants/baseboard/gpio.c +++ b/src/mainboard/google/volteer/variants/baseboard/gpio.c @@ -260,6 +260,8 @@ PAD_NC(GPP_F9, NONE), /* F10 : GPPF10_STRAP */ PAD_NC(GPP_F10, DN_20K), + /* F11 : THC1_SPI2_CLK ==> EN_PP3300_WWAN */ + PAD_CFG_GPO(GPP_F11, 1, DEEP), /* F12 : GSXDOUT ==> NC */ PAD_NC(GPP_F12, NONE), /* F13 : GSXDOUT ==> NC */

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Paul Menzel (Code Review)

25 Aug 25 Aug

11:51 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44745 )

Change subject: mb/google/volteer: add GPP_F11 to baseboard gpio_table. ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44745/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44745/3//COMMIT_MSG@7 PS3, Line 7: mb/google/volteer: add GPP_F11 to baseboard gpio_table. Please remove the dot/period at the end of the git commit message.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40f887300a9dfd4f8e790031b77bbee8a014f499 Gerrit-Change-Number: 44745 Gerrit-PatchSet: 3 Gerrit-Owner: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 25 Aug 2020 21:51:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nick Vaccaro (Code Review)

26 Aug 26 Aug

12:10 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: add GPP_F11 to baseboard gpio_table

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44745

to look at the new patch set (#4).

Change subject: mb/google/volteer: add GPP_F11 to baseboard gpio_table ......................................................................

mb/google/volteer: add GPP_F11 to baseboard gpio_table

GPP_F11 was in the early gpio table, but the definition was missing from the main gpio_table. This change adds GPP_F11 to the gpio_table array.

BUG=none TEST="emerge-volteer coreboot" and verify it builds correctly.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/44745/4

Nick Vaccaro (Code Review)

12:23 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: add GPP_F11 to baseboard gpio_table

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44745

to look at the new patch set (#6).

Change subject: mb/google/volteer: add GPP_F11 to baseboard gpio_table ......................................................................

mb/google/volteer: add GPP_F11 to baseboard gpio_table

GPP_F11 was in the early gpio table, but the definition was missing from the main gpio_table. This change adds GPP_F11 to the gpio_table array.

BUG=none TEST="emerge-volteer coreboot" and verify it builds correctly.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/44745/6

Nick Vaccaro (Code Review)

2:11 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: add GPP_F11 to baseboard gpio_table

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44745 )

Change subject: mb/google/volteer: add GPP_F11 to baseboard gpio_table ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44745/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44745/3//COMMIT_MSG@7 PS3, Line 7: mb/google/volteer: add GPP_F11 to baseboard gpio_table.

...

Please remove the dot/period at the end of the git commit message.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/44745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40f887300a9dfd4f8e790031b77bbee8a014f499 Gerrit-Change-Number: 44745 Gerrit-PatchSet: 6 Gerrit-Owner: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 26 Aug 2020 12:11:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Caveh Jalali (Code Review)

11:51 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: add GPP_F11 to baseboard gpio_table

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44745 )

Change subject: mb/google/volteer: add GPP_F11 to baseboard gpio_table ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40f887300a9dfd4f8e790031b77bbee8a014f499 Gerrit-Change-Number: 44745 Gerrit-PatchSet: 6 Gerrit-Owner: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 26 Aug 2020 21:51:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

31 Aug 31 Aug

8:31 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: add GPP_F11 to baseboard gpio_table

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44745 )

Change subject: mb/google/volteer: add GPP_F11 to baseboard gpio_table ......................................................................

mb/google/volteer: add GPP_F11 to baseboard gpio_table

GPP_F11 was in the early gpio table, but the definition was missing from the main gpio_table. This change adds GPP_F11 to the gpio_table array.

BUG=none TEST="emerge-volteer coreboot" and verify it builds correctly.

Change-Id: I40f887300a9dfd4f8e790031b77bbee8a014f499 Signed-off-by: Nick Vaccaro nvaccaro@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44745 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Caveh Jalali caveh@chromium.org --- M src/mainboard/google/volteer/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/44745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40f887300a9dfd4f8e790031b77bbee8a014f499 Gerrit-Change-Number: 44745 Gerrit-PatchSet: 7 Gerrit-Owner: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

10:51 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: add GPP_F11 to baseboard gpio_table

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44745 )

Change subject: mb/google/volteer: add GPP_F11 to baseboard gpio_table ......................................................................

Patch Set 7:

Automatic boot test returned (PASS/FAIL/TOTAL): 6/1/7 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17216 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17215 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/17214 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17213 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/17212 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17218 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17217

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/44745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40f887300a9dfd4f8e790031b77bbee8a014f499 Gerrit-Change-Number: 44745 Gerrit-PatchSet: 7 Gerrit-Owner: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 31 Aug 2020 08:51:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1528

days inactive

1535

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Caveh Jalali (Code Review)
Nick Vaccaro (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)