Change in coreboot[master]: ec/system76: undefine PECI gpio in ACPI to prevent build failure - coreboot-gerrit

13 Sep 2020


      Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45323 )
Change subject: ec/system76: undefine PECI gpio in ACPI to prevent build failure
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45323/2//COMMIT_MSG 
Commit Message:
https://review.coreboot.org/c/coreboot/+/45323/2//COMMIT_MSG@9 
PS2, Line 9: PECI
...
Why not rename the GPIO definition?
because I named them by their actual names in datasheet and schematics, to make searching in code/schematics easier. however, what about PECI_IO?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/45323
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60b752b906d95f858195965544d91c0b9cc9ff8a
Gerrit-Change-Number: 45323
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller jeremy@system76.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 13 Sep 2020 16:43:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment