Attention is currently required from: Hung-Te Lin, Jarried Lin, Zhanzhan Ge.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83928?usp=email )
Change subject: soc/mediatek/mt8196: Fix timer reset in BL31 ......................................................................
Patch Set 23:
(1 comment)
File src/soc/mediatek/mt8196/timer_prepare.c:
https://review.coreboot.org/c/coreboot/+/83928/comment/b3f5fcd7_ef3ff119?usp... : PS23, Line 18: write32
Dear yuping: […]
Yes, there are still many `setbits32` calls in coreboot, because `SET32_BITFIELDS` is the new API. See CB:35463 for the benefits of the new API. I admit I didn't require using the new API when reviewing all the coreboot patches. However, since hungte@ pointed that out in this patch in another comment, I think we should follow his suggestion.
About how to use the new API, see src/soc/mediatek/mt8188/msdc.c as an example. It will be just a few lines of changes in this file. If you are still not sure how to write the code, please let me know.
-
Yu-Ping Wu (Code Review)