Attention is currently required from: Balaji Manigandan, Jamie Ryu, Subrata Banik, Tarun Tuli, Usha P, Utkarsh H Patel, Utkarsh H Patel, Vikrant Jadeja.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75717?usp=email )
Change subject: intelblocks/pep: Restrict TBT displays(DPOF) on S0ix transition to FWCM.
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75717/comment/52ff5fc5_a48d83ee :
PS3, Line 7: .
No periods in commit titles.
https://review.coreboot.org/c/coreboot/+/75717/comment/8ea58593_0cec6cb7 :
PS3, Line 9: IOM needed to be notified about DPOF(TBT Displays OFF) only when Firmware connection Manager in use during S0ix Entry/Exit.
Reflow for 72 chars per line
File src/soc/intel/common/block/acpi/pep.c:
https://review.coreboot.org/c/coreboot/+/75717/comment/b4fec88b_1272304a :
PS3, Line 278: #if CONFIG(FIRMWARE_CONNECTION_MANAGER)
Please don't use preprocessor ifs when possible. For cases like this, just go with C code. The compiler will remove the code in case of `if (0)`.
```
if (CONFIG(FIRMWARE_CONNECTION_MANAGER)) {
...
}
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75717?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I110fb971846f110e7d93a524ceda3bf4bfc15c13
Gerrit-Change-Number: 75717
Gerrit-PatchSet: 3
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.corp-partner.google.com
Gerrit-Reviewer: Vikrant Jadeja
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Vikrant Jadeja
Gerrit-Attention: Utkarsh H Patel
utkarsh.h.patel@intel.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Attention: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Comment-Date: Thu, 15 Jun 2023 22:39:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment