Attention is currently required from: Raul Rangel, Paul Menzel, Karthik Ramasubramanian. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62165 )
Change subject: mb/google/skyrim: Configure WLAN ......................................................................
Patch Set 30:
(4 comments)
File src/mainboard/google/skyrim/romstage.c:
https://review.coreboot.org/c/coreboot/+/62165/comment/f4ac2d52_64b430c3 PS29, Line 12: variant_pcie_gpio_table(&base_gpios, &base_num_gpios);
You are getting the GPIO table, but not programming them.
Ack
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/62165/comment/c9e176cc_7a3d0f45 PS29, Line 52: "GEVENT_14"
Skyrim is using GPIO2/GEVENT8 for Wake on WLAN.
Ack
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/62165/comment/3d2d8e21_78b7f151 PS29, Line 167: WLAN_AUX_RESET (ACTIVE LOW)
Nit: WLAN_AUX_RESET_L. […]
Done
https://review.coreboot.org/c/coreboot/+/62165/comment/9870545f_6a66ba77 PS29, Line 169: & WWAN
Nit: Add WWAN when you are introducing those GPIOs as well.
Done
-
Jon Murphy (Code Review)