Attention is currently required from: Andrey Petrov, Dinesh Gehlot, Paul Menzel, Ronak Kanabar, Subrata Banik.
Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83770?usp=email )
Change subject: drivers/intel/fsp2: Add config for FSP uGOP eSOL ......................................................................
Patch Set 7:
(3 comments)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/83770/comment/e3c7f8b6_05dd2f2f?usp... : PS6, Line 477: sign of life
In the current code base it’s spelled Sign-of-Life. (No idea, if we should stay consistent. […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/83770/comment/494bbcf0_6d5357fd?usp... : PS6, Line 475: Enable the FSP-M Sign-of-Life feature to display a text message : on screen during memory training and CSME update. This utilizes Intel's underlying uGOP : technology to enable early sign of life (eSOL) as part of FSP-M.
Please re-flow.
Acknowledged
https://review.coreboot.org/c/coreboot/+/83770/comment/64c72d39_bb6e4d07?usp... : PS6, Line 476: This utilizes Intel's underlying uGOP : technology
Is this too much marketing speech? Maybe: […]
Acknowledged