Attention is currently required from: Kenneth Chan, Karthik Ramasubramanian.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63753 )
Change subject: mb/google/guybrush/var/dewatt: Override SPI fast speed
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63753/comment/d8e93527_9bd17601
PS1, Line 9: 100 MHz SPI fast speed can be
: enabled for SPI ROM.
Awesome!
File src/mainboard/google/guybrush/Kconfig:
https://review.coreboot.org/c/coreboot/+/63753/comment/c3b2526b_1402398e
PS1, Line 140: default 0x3 if BOARD_GOOGLE_DEWATT
Nit: Could we get a comment like the lines above saying what the speed for '3' is?
Really it could go on all of these, but if you could do it for dewatt, that'd be a start.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63753
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a3022d54bcec70f6b12492f494d3019e00d204a
Gerrit-Change-Number: 63753
Gerrit-PatchSet: 1
Gerrit-Owner: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
martinroth@google.com
Gerrit-Attention: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 21 Apr 2022 03:59:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment