Attention is currently required from: Raul Rangel, Rob Barnes. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52143 )
Change subject: mb/google/guybrush: Unmask eSPI keyboard IRQ ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
I think in the long run we should have espi_util unmask these if they are configured for eSPI.
+1. We already have vw_irq_polarity. We can extend that to ensure that the interrupts are correctly configured. Can you please file a bug to track it?
File src/mainboard/google/guybrush/mainboard.c:
https://review.coreboot.org/c/coreboot/+/52143/comment/eff55fcd_86813cf6 PS3, Line 119: pm_write32(PM_ESPI_INTR_CTRL, PM_ESPI_DEV_INTR_MASK & ~(BIT(1))); I think this should be done as part of `espi_configure()`. Probably add a new config in `struct espi_config{}` and use that? This will be required for all the eSPI interrupts that are used by the mainboard and so needs to go hand-in-hand with vw_irq_polarity.
-
Furquan Shaikh (Code Review)