Attention is currently required from: Jason Nien, Martin Roth, Felix Held.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68634 )
Change subject: mb/google/kahlee: use override devicetrees for variants ......................................................................
Patch Set 3:
(4 comments)
File src/mainboard/google/kahlee/variants/aleena/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68634/comment/53fb52e3_4a75f8b2 PS3, Line 38: chip drivers/generic/adau7002 : device generic 0.0 on end : end can move to baseboard
https://review.coreboot.org/c/coreboot/+/68634/comment/65095064_bcc8ac96 PS3, Line 59: chip drivers/generic/max98357a : register "hid" = ""MX98357A"" : register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_119)" : register "sdmode_delay" = "5" : device generic 0.1 on end : end can go to baseboard too
https://review.coreboot.org/c/coreboot/+/68634/comment/f34c57d0_224631bb PS3, Line 67: chip drivers/i2c/generic : register "hid" = ""ELAN0000"" : register "desc" = ""ELAN Touchpad"" : register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)" : register "wake" = "7" : register "detect" = "1" : device i2c 15 on end : end FYI, I tested on LIARA moving the ELAN touchpad to the baseboard and leaving the other (synaptics) in the overridetree, and coreboot will pick up / attempt detection on both. So good to move ELAN pad to baseboard
https://review.coreboot.org/c/coreboot/+/68634/comment/ef48c835_6bbf6567 PS3, Line 85: device ref i2c_3 on : chip drivers/i2c/generic : register "hid" = ""RAYD0001"" : register "desc" = ""Raydium Touchscreen"" : register "probed" = "1" : register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_11)" : register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_85)" : register "reset_delay_ms" = "20" : register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)" : register "enable_delay_ms" = "1" : register "has_power_resource" = "1" : device i2c 39 on end : end : chip drivers/i2c/generic : register "hid" = ""ELAN0001"" : register "desc" = ""ELAN Touchscreen"" : register "probed" = "1" : register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_11)" : register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_85)" : register "reset_delay_ms" = "20" : register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)" : register "enable_delay_ms" = "1" : register "has_power_resource" = "1" : device i2c 10 on end : end : end same here - the ELAN and Raydium touchscreens are common and can be moved to the baseboard
-
Matt DeVillier (Code Review)