Attention is currently required from: David Wu, Paul Menzel, Tim Wawrzynczak, Zhuohao Lee. Alan Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59086 )
Change subject: drivers/net/r8168: Add support for Realtek RT8125 ......................................................................
Patch Set 12:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59086/comment/8086e2be_f5abcc79 PS2, Line 7: mb/google/brya/var/brask: Make LAN driver to support RT8125
Ack
Done
https://review.coreboot.org/c/coreboot/+/59086/comment/05ff9672_548f211b PS2, Line 8: : Add new device id 0x8125 to the driver.
Ack
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/59086/comment/3d296b5c_247a2b91 PS7, Line 9: The Realtek RT8168 and RT8125 have a similar programming : interface, therefore add the PCI device ID for the RT8125 : into driver for support.
Fixed.
Done
https://review.coreboot.org/c/coreboot/+/59086/comment/24babf17_2dc89f5b PS7, Line 14: TEST=emerge-brask coreboot chromeos-bootimage
Added the testing detail in the message.
Done
File src/drivers/net/r8168.c:
https://review.coreboot.org/c/coreboot/+/59086/comment/29a7d2b0_d7f39710 PS2, Line 364: 0x8168, : 0x8125,
Ack
Done
https://review.coreboot.org/c/coreboot/+/59086/comment/174988d0_22aa5d57 PS2, Line 371: 0x10ec
Ack
Done
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/59086/comment/5f4900ae_05a44444 PS7, Line 1287: #define PCI_DEVICE_ID_REALTEK_8125 0x8125
Sorted.
Done
-
Alan Huang (Code Review)