Attention is currently required from: Ronald Claveau.
Nicholas Chin has posted comments on this change by Ronald Claveau. ( https://review.coreboot.org/c/coreboot/+/83104?usp=email )
Change subject: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge)
......................................................................
Patch Set 15:
(1 comment)
File src/mainboard/dell/xps_8300/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/83104/comment/a97791af_09933ba6?usp... :
PS15, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
Should be CC-PDDC as per commit cf4722d317ea (src/mb: Update unlicensable files with the CC-PDDC SPDX ID)
```suggestion
/* SPDX-License-Identifier: CC-PDDC */
/* Please update the license if adding licensable material. */
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83104?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7d394794fec580bc7aed3f6396ceb47d4a6fd059
Gerrit-Change-Number: 83104
Gerrit-PatchSet: 15
Gerrit-Owner: Ronald Claveau
sousmangoosta@aliel.fr
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ronald Claveau
sousmangoosta@aliel.fr
Gerrit-Comment-Date: Tue, 09 Jul 2024 03:04:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No