Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31902 )
Change subject: soc/intel/cannonlake: Clear PMCON status bits
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/31902/4/src/soc/intel/cannonlake/finalize.c
File src/soc/intel/cannonlake/finalize.c:
https://review.coreboot.org/#/c/31902/4/src/soc/intel/cannonlake/finalize.c@...
PS4, Line 56: pmc_clear_pmcon_sts
Shouldn't this function live in pmutil.c?
https://review.coreboot.org/#/c/31902/4/src/soc/intel/cannonlake/finalize.c@...
PS4, Line 65: reg_val |= (SUS_PWR_FLR | GBL_RST_STS | HOST_RST_STS | PWR_FLR);
Why is this required? Since you are reading GEN_PMCON_A, writing back the same value & ~(MS4V) should take care of clearing any status bits?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31902
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9863d52ed3c61b6a160df53f023b0787eaaed68
Gerrit-Change-Number: 31902
Gerrit-PatchSet: 4
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 22 Mar 2019 00:28:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment