Shaunak Saha has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42415 )
Change subject: mb/google/volteer: Enable SATA Port Dito Config ......................................................................
mb/google/volteer: Enable SATA Port Dito Config
Enable SataPortsEnableDitoConfig for port 0 and 1.
BUG=b:151163106 BRANCH=None TEST=Build and boot volteer.
Signed-off-by: Shaunak Saha shaunak.saha@intel.com Change-Id: I552faaa0e7172e77208025cf4251bb848cc90709 --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/42415/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 8ff790e..baf4c97 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -98,6 +98,8 @@ register "SataPortsEnable[1]" = "1" register "SataPortsDevSlp[0]" = "0" register "SataPortsDevSlp[1]" = "1" + register "SataPortsEnableDitoConfig[0]" = "1" + register "SataPortsEnableDitoConfig[1]" = "1"
register "SerialIoI2cMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoPci,
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42415 )
Change subject: mb/google/volteer: Enable SATA Port Dito Config ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42415/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42415/1//COMMIT_MSG@13 PS1, Line 13: TEST=Build and boot volteer. Where you able to measure the power savings?
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42415 )
Change subject: mb/google/volteer: Enable SATA Port Dito Config ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42415/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42415/1/src/mainboard/google/voltee... PS1, Line 101: 1 port0 is disabled, should this also be disabled?
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42415 )
Change subject: mb/google/volteer: Enable SATA Port Dito Config ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42415/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42415/1//COMMIT_MSG@13 PS1, Line 13: TEST=Build and boot volteer.
Where you able to measure the power savings?
I do not have the exact data now. I am checking with our PnP team for the power numbers.
https://review.coreboot.org/c/coreboot/+/42415/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42415/1/src/mainboard/google/voltee... PS1, Line 101: 1
port0 is disabled, should this also be disabled?
Agreed. Will fix.
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Duncan Laurie, Srinidhi N Kaushik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42415
to look at the new patch set (#2).
Change subject: mb/google/volteer: Enable SATA Port Dito Config ......................................................................
mb/google/volteer: Enable SATA Port Dito Config
iEnable SataPortsEnableDitoConfig for port 1.
BUG=b:151163106 BRANCH=None TEST=Build and boot volteer.
Signed-off-by: Shaunak Saha shaunak.saha@intel.com Change-Id: I552faaa0e7172e77208025cf4251bb848cc90709 --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/42415/2
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42415 )
Change subject: mb/google/volteer: Enable SATA Port Dito Config ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42415/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42415/1//COMMIT_MSG@13 PS1, Line 13: TEST=Build and boot volteer.
I do not have the exact data now. I am checking with our PnP team for the power numbers.
I tried to measure the power savings but for TGL we were not able to measure this time. I will update this patch and internal BUG as i have the data.
https://review.coreboot.org/c/coreboot/+/42415/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42415/1/src/mainboard/google/voltee... PS1, Line 101: 1
Agreed. Will fix.
Done
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42415 )
Change subject: mb/google/volteer: Enable SATA Port Dito Config ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42415/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42415/1//COMMIT_MSG@13 PS1, Line 13: TEST=Build and boot volteer.
I tried to measure the power savings but for TGL we were not able to measure this time. […]
Done
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42415 )
Change subject: mb/google/volteer: Enable SATA Port Dito Config ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42415/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42415/2//COMMIT_MSG@9 PS2, Line 9: iEnable Enable?
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42415 )
Change subject: mb/google/volteer: Enable SATA Port Dito Config ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42415/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42415/2//COMMIT_MSG@9 PS2, Line 9: iEnable
Enable?
Looks like a vim user. ;-)
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42415 )
Change subject: mb/google/volteer: Enable SATA Port Dito Config ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42415/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42415/2//COMMIT_MSG@9 PS2, Line 9: iEnable
Looks like a vim user. […]
@Caveh. Thanks for catching that. Will Fix. @Paul. You are right. Have that i problem lot of time. Maybe time to switch to emacs for good 😊
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Caveh Jalali, Duncan Laurie, Nick Vaccaro, Srinidhi N Kaushik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42415
to look at the new patch set (#3).
Change subject: mb/google/volteer: Enable SATA Port Dito Config ......................................................................
mb/google/volteer: Enable SATA Port Dito Config
Enable SataPortsEnableDitoConfig for port 1.
BUG=b:151163106 BRANCH=None TEST=Build and boot volteer.
Signed-off-by: Shaunak Saha shaunak.saha@intel.com Change-Id: I552faaa0e7172e77208025cf4251bb848cc90709 --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/42415/3
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42415 )
Change subject: mb/google/volteer: Enable SATA Port Dito Config ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42415/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42415/2//COMMIT_MSG@9 PS2, Line 9: iEnable
@Caveh. Thanks for catching that. Will Fix. […]
Done
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42415 )
Change subject: mb/google/volteer: Enable SATA Port Dito Config ......................................................................
Patch Set 3: Code-Review+2
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42415 )
Change subject: mb/google/volteer: Enable SATA Port Dito Config ......................................................................
Patch Set 4: Code-Review+2
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42415 )
Change subject: mb/google/volteer: Enable SATA Port Dito Config ......................................................................
Patch Set 4:
Can you also create patch for TGLRVP?
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42415 )
Change subject: mb/google/volteer: Enable SATA Port Dito Config ......................................................................
mb/google/volteer: Enable SATA Port Dito Config
Enable SataPortsEnableDitoConfig for port 1.
BUG=b:151163106 BRANCH=None TEST=Build and boot volteer.
Signed-off-by: Shaunak Saha shaunak.saha@intel.com Change-Id: I552faaa0e7172e77208025cf4251bb848cc90709 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42415 Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com Reviewed-by: Caveh Jalali caveh@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved Wonkyu Kim: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 18bfcc4..f0bb25b 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -110,6 +110,7 @@ register "SataPortsEnable[1]" = "1" register "SataPortsDevSlp[0]" = "0" register "SataPortsDevSlp[1]" = "1" + register "SataPortsEnableDitoConfig[1]" = "1"
register "SerialIoI2cMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoPci,