Attention is currently required from: Andrey Petrov, Felix Held.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69475 )
Change subject: drivers/intel/fsp2_0/hand_off_block: add functions to iterate over HOBs
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/intel/fsp2_0/hand_off_block.c:
https://review.coreboot.org/c/coreboot/+/69475/comment/2bdd7471_53c13721
PS1, Line 140: while ((*hob_iterator)->type != HOB_TYPE_END_OF_HOB_LIST) {
Do we want to add way to exit the loop for these functions in case the hob list is messed up for some reason?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69475
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If86dde2a9f41d0ca7941493a92f11b91a77e2ae0
Gerrit-Change-Number: 69475
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 13 Nov 2022 15:48:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment