Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33866
Change subject: payloads/coreinfo: Enable -Wmissing-prototypes ......................................................................
payloads/coreinfo: Enable -Wmissing-prototypes
Change-Id: I7ee9436ba71ceea35a35272291ea245c0b7c37c5 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M payloads/coreinfo/Makefile 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/33866/1
diff --git a/payloads/coreinfo/Makefile b/payloads/coreinfo/Makefile index 1a34dbe..38e5bac 100644 --- a/payloads/coreinfo/Makefile +++ b/payloads/coreinfo/Makefile @@ -83,7 +83,8 @@ LPCC := CC="$(CC)" $(LIBPAYLOAD_OBJ)/bin/lpgcc LPAS := AS="$(AS)" $(LIBPAYLOAD_OBJ)/bin/lpas
-CFLAGS += -Wall -Wextra -Os -fno-builtin $(CFLAGS_$(ARCH-y)) $(INCLUDES) +CFLAGS += -Wall -Wextra -Wmissing-prototypes +CFLAGS += -Os -fno-builtin $(CFLAGS_$(ARCH-y)) $(INCLUDES)
ifneq ($(strip $(HAVE_DOTCONFIG)),) include $(src)/.config
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33866 )
Change subject: payloads/coreinfo: Enable -Wmissing-prototypes ......................................................................
Patch Set 1: Code-Review+2
Hello HAOUAS Elyes, David Hendricks, Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33866
to look at the new patch set (#2).
Change subject: payloads/coreinfo: Enable -Wmissing-prototypes ......................................................................
payloads/coreinfo: Enable -Wmissing-prototypes
Change-Id: I7ee9436ba71ceea35a35272291ea245c0b7c37c5 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M payloads/coreinfo/Makefile 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/33866/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33866 )
Change subject: payloads/coreinfo: Enable -Wmissing-prototypes ......................................................................
Patch Set 2: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33866 )
Change subject: payloads/coreinfo: Enable -Wmissing-prototypes ......................................................................
payloads/coreinfo: Enable -Wmissing-prototypes
Change-Id: I7ee9436ba71ceea35a35272291ea245c0b7c37c5 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/33866 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M payloads/coreinfo/Makefile 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/payloads/coreinfo/Makefile b/payloads/coreinfo/Makefile index a98342f..1e9eb80 100644 --- a/payloads/coreinfo/Makefile +++ b/payloads/coreinfo/Makefile @@ -83,7 +83,8 @@ LPCC := CC="$(CC)" $(LIBPAYLOAD_OBJ)/bin/lpgcc LPAS := AS="$(AS)" $(LIBPAYLOAD_OBJ)/bin/lpas
-CFLAGS += -Wall -Wextra -Werror -Os -fno-builtin $(CFLAGS_$(ARCH-y)) $(INCLUDES) +CFLAGS += -Wall -Wextra -Wmissing-prototypes -Werror +CFLAGS += -Os -fno-builtin $(CFLAGS_$(ARCH-y)) $(INCLUDES)
ifneq ($(strip $(HAVE_DOTCONFIG)),) include $(src)/.config