Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Patrick Rudolph, EricR Lai.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56382 )
Change subject: soc/intel/alderlake: Refactor MultiPhaseSiInit API calling method
......................................................................
Patch Set 9:
(1 comment)
File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/56382/comment/07d61178_8f66a06e
PS8, Line 80: #endif
Right, so TGL has an UPD to enable multi-phase Si init, but it's not in the FSPS_ARCH_UPD... […]
The problem with using a __weak definition for `enable_multi_phase_init()` is that it doesn't do anything when CONFIG_FSPS_HAS_ARCH_UPD=n and SoC doesn't provide an override. In this case, it's possible to call FSP-S without setting `EnableMultiPhaseSiliconInit` even when CONFIG_FSPS_USE_MULTI_PHASE_INIT=y, which can cause issues.
By guarding the entire function definition and not using __weak, SoCs with CONFIG_FSPS_USE_MULTI_PHASE_INIT=y and CONFIG_FSPS_HAS_ARCH_UPD=n are required to define `enable_multi_phase_init()`. Otherwise, building fails.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56382
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I019fa8364605f5061d56e2d80b20e1a91857c423
Gerrit-Change-Number: 56382
Gerrit-PatchSet: 9
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 08 Sep 2021 11:27:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment