HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31924
Change subject: src: Drop unused 'include <device/pciexp.h>' ......................................................................
src: Drop unused 'include <device/pciexp.h>'
Change-Id: I9b4d72116a66d5a256659fa82682497ef3481e77 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/device/pci_class.c M src/soc/intel/broadwell/serialio.c M src/southbridge/intel/common/pciehp.c M src/southbridge/intel/lynxpoint/serialio.c 4 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/31924/1
diff --git a/src/device/pci_class.c b/src/device/pci_class.c index aa28ce8..d9c3a4f 100644 --- a/src/device/pci_class.c +++ b/src/device/pci_class.c @@ -17,7 +17,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <device/pciexp.h> #include <device/pci_ids.h> #include <stdlib.h>
diff --git a/src/soc/intel/broadwell/serialio.c b/src/soc/intel/broadwell/serialio.c index 59fb4f7..12e458c 100644 --- a/src/soc/intel/broadwell/serialio.c +++ b/src/soc/intel/broadwell/serialio.c @@ -19,7 +19,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pciexp.h> #include <device/pci_ids.h> #include <stdlib.h> #include <soc/iobp.h> diff --git a/src/southbridge/intel/common/pciehp.c b/src/southbridge/intel/common/pciehp.c index ea48d9e..8ff41b3 100644 --- a/src/southbridge/intel/common/pciehp.c +++ b/src/southbridge/intel/common/pciehp.c @@ -19,7 +19,7 @@ #include <arch/acpigen.h> #include <device/device.h> #include <device/pci.h> -#include <device/pciexp.h> + #include "pciehp.h"
void intel_acpi_pcie_hotplug_generator(u8 *hotplug_map, int port_number) diff --git a/src/southbridge/intel/lynxpoint/serialio.c b/src/southbridge/intel/lynxpoint/serialio.c index 5224f68..f5c52ef 100644 --- a/src/southbridge/intel/lynxpoint/serialio.c +++ b/src/southbridge/intel/lynxpoint/serialio.c @@ -20,7 +20,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pciexp.h> #include <device/pci_ids.h> #include <stdlib.h> #include "pch.h"
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31924 )
Change subject: src: Drop unused 'include <device/pciexp.h>' ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31924 )
Change subject: src: Drop unused 'include <device/pciexp.h>' ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31924 )
Change subject: src: Drop unused 'include <device/pciexp.h>' ......................................................................
src: Drop unused 'include <device/pciexp.h>'
Change-Id: I9b4d72116a66d5a256659fa82682497ef3481e77 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/31924 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/device/pci_class.c M src/soc/intel/broadwell/serialio.c M src/southbridge/intel/common/pciehp.c M src/southbridge/intel/lynxpoint/serialio.c 4 files changed, 1 insertion(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/src/device/pci_class.c b/src/device/pci_class.c index aa28ce8..d9c3a4f 100644 --- a/src/device/pci_class.c +++ b/src/device/pci_class.c @@ -17,7 +17,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <device/pciexp.h> #include <device/pci_ids.h> #include <stdlib.h>
diff --git a/src/soc/intel/broadwell/serialio.c b/src/soc/intel/broadwell/serialio.c index 59fb4f7..12e458c 100644 --- a/src/soc/intel/broadwell/serialio.c +++ b/src/soc/intel/broadwell/serialio.c @@ -19,7 +19,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pciexp.h> #include <device/pci_ids.h> #include <stdlib.h> #include <soc/iobp.h> diff --git a/src/southbridge/intel/common/pciehp.c b/src/southbridge/intel/common/pciehp.c index ea48d9e..8ff41b3 100644 --- a/src/southbridge/intel/common/pciehp.c +++ b/src/southbridge/intel/common/pciehp.c @@ -19,7 +19,7 @@ #include <arch/acpigen.h> #include <device/device.h> #include <device/pci.h> -#include <device/pciexp.h> + #include "pciehp.h"
void intel_acpi_pcie_hotplug_generator(u8 *hotplug_map, int port_number) diff --git a/src/southbridge/intel/lynxpoint/serialio.c b/src/southbridge/intel/lynxpoint/serialio.c index 5224f68..f5c52ef 100644 --- a/src/southbridge/intel/lynxpoint/serialio.c +++ b/src/southbridge/intel/lynxpoint/serialio.c @@ -20,7 +20,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pciexp.h> #include <device/pci_ids.h> #include <stdlib.h> #include "pch.h"
-
Arthur Heymans (Code Review) -
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)