Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71218 )
Change subject: mb/google/nissa/var/craask: Use get_wifi_sar_fw_config_filename
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
Will drop SAR_UNUSED 7 in factory.
I'm not sure what you mean by drop it. Currently SAR_UNUSED is used for craaskvin, which uses Intel wifi but does not have a SAR table. If we drop it, what setting will be used on craaskvin?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71218
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04176fee373e534d42c72506df73a092ad55e65b
Gerrit-Change-Number: 71218
Gerrit-PatchSet: 2
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Wed, 04 Jan 2023 01:54:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment