Attention is currently required from: Sridhar Siricilla, Rizwan Qureshi, Werner Zeh. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56073 )
Change subject: mb/intel/adlrvp: Update PMC Descriptor for Alder lake A0(906a0h) silicon ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56073/comment/4dd422ba_e0051b0e PS2, Line 7: mb/intel/adlrvp: Update PMC Descriptor for Alder lake A0(0x906a0) silicon
The headline of the commit message is limited to 72 characters.
Ack
https://review.coreboot.org/c/coreboot/+/56073/comment/4f7200bf_d6c935c5 PS2, Line 16: TEST=Verified PMC Descriptor getting modified for Alder lake B0 silicon if : not updated.
Please use proper line length.
Ack
File src/mainboard/intel/adlrvp/bootblock.c:
https://review.coreboot.org/c/coreboot/+/56073/comment/49216766_2647305a PS1, Line 5: #include <console/console.h>
We do sort our include in an alphabetical order.
Ack
https://review.coreboot.org/c/coreboot/+/56073/comment/9f98cab8_d1d4f71c PS1, Line 9: include <console/console.h>
This include is already there on line 5.
Ack