Attention is currently required from: Bao Zheng, Zheng Bao.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72456 )
Change subject: amdfwtool: Parse the line with SOC_NAME ......................................................................
Patch Set 2:
(1 comment)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/72456/comment/74839a70_a071df81 PS2, Line 651: } else if (strcmp(&(oneline[match[1].rm_so]), "SOC_NAME") == 0) { : /* TODO: Add back later */ : /* cb_config->soc_id = : identify_platform(&(oneline[match[2].rm_so])); */ This else-if block should be added in CB:58552 since it is not necessary until then. That would avoid adding a "TODO" comment here that is removed there.