Attention is currently required from: Felix Singer, Tim Wawrzynczak, Nick Vaccaro.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60370 )
Change subject: mb/google/volteer: Select board-specific options per board
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/60370/comment/46282456_43bac7c5
PS3, Line 30: select MAINBOARD_HAS_CHROMEOS
I wonder if this would work:
select MAINBOARD_HAS_SPI_TPM_CR50 if !MAINBOARD_HAS_I2C_TPM_CR50
This would choose `MAINBOARD_HAS_SPI_TPM_CR50` by default unless `MAINBOARD_HAS_I2C_TPM_CR50` is selected.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60370
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c5305a764b7a362f9f381580a1cd2c20a8f2e9d
Gerrit-Change-Number: 60370
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 28 Dec 2021 11:48:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment