Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Sean Rhodes, Sergii Dmytruk.
Krystian Hebel has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83682?usp=email )
Change subject: payloads/external/edk2: configure capsule updates
......................................................................
Patch Set 1:
(1 comment)
File payloads/external/edk2/Makefile:
https://review.coreboot.org/c/coreboot/+/83682/comment/6a62e09d_db0b181c?usp... :
PS1, Line 151: ifneq ($(CONFIG_DRIVERS_EFI_UPDATE_CAPSULES),)
This is inside `ifeq ($(CONFIG_EDK2_REPO_MRCHROMEBOX),y)`, shouldn't this be part of upstream edk2 or at least common options instead?
Possibly related to discussion in CB:82721
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83682?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c684cb8929842a5d3c4b06e8a9c0a748470ea41
Gerrit-Change-Number: 83682
Gerrit-PatchSet: 1
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Tue, 30 Jul 2024 10:23:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No