Attention is currently required from: Jason Glenesk, Matt DeVillier, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69410 )
Change subject: soc/amd/[glinda|morgana]: Enable override of MAINBOARD_BLOBS_DIR
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/glinda/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/69410/comment/2cd3f0af_925a366d
PS1, Line 61: MAINBOARD_BLOBS_DIR:=$
we already do this for MDN which is fine, but it seems a little odd to me that we define the MAINBOA […]
Good idea - looks like I could move it from SoC-specific Makefile to the amd common makefile.
However, I'm starting to wonder if it would make more sense to just change this to a Kconfig option with a default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)" and let users/config override it for site-local or other locations?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69410
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0702fdb97fbc2c73d97994ab4d5161ff0f467518
Gerrit-Change-Number: 69410
Gerrit-PatchSet: 1
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 11 Nov 2022 19:03:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-MessageType: comment