Attention is currently required from: Jamie Ryu, Paul Menzel, Sridhar Siricilla, Usha P, Eric Lai.
Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72706 )
Change subject: mb/intel/mtlrvp: Enable GSPI interface
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72706/comment/d25a322f_f26b472b
PS1, Line 7: for mtlrvp
Redundant as in prefix.
Ack
https://review.coreboot.org/c/coreboot/+/72706/comment/38188793_e56e39d5
PS1, Line 9: GSPI[1]
Please add a space before the [.
Ack
https://review.coreboot.org/c/coreboot/+/72706/comment/8a8fc868_ae53efc1
PS1, Line 15: chromeOS
ChromeOS
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72706
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d4c4f19dd80fefa80c365b5ecac0a234f5af860
Gerrit-Change-Number: 72706
Gerrit-PatchSet: 2
Gerrit-Owner: Harsha B R
harsha.b.r@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Feb 2023 14:51:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment