Attention is currently required from: Raul Rangel, Rob Barnes, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58705 )
Change subject: mb/google/guybrush: Define ACPI Power Resources for FPMCU
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/58705/comment/5d99e02d_6117bf39
PS4, Line 178: enable_delay_ms
Actually, do we also want enable_off_delay_ms = 200?
We are actually configuring the enable GPIO to TX state '0' (i.e. disable) in ramstage. The GPIO gets set to enabled state when the control jumps to OS. That will help to meet the enable_off_delay_ms requirement.
I did this because _OFF method does not get invoked during shutdown or warm reset.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58705
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52322eaecf6961ff9a196ca9ab2d58b7d4599d4f
Gerrit-Change-Number: 58705
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-CC: Craig Hesling
hesling@chromium.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 08 Nov 2021 17:47:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment