Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59115 )
Change subject: azalia_device: Report if codec verb loading failed ......................................................................
azalia_device: Report if codec verb loading failed
Handle the return value of `azalia_program_verb_table()` and print different messages accordingly.
Change-Id: I99e9e1416217c5e67c529944736affb31f9c7d2f Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/device/azalia_device.c 1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/59115/1
diff --git a/src/device/azalia_device.c b/src/device/azalia_device.c index c3bb91b..c390db1 100644 --- a/src/device/azalia_device.c +++ b/src/device/azalia_device.c @@ -261,8 +261,11 @@ printk(BIOS_DEBUG, "azalia_audio: verb_size: %u\n", verb_size);
/* 3 */ - azalia_program_verb_table(base, verb, verb_size); - printk(BIOS_DEBUG, "azalia_audio: verb loaded.\n"); + const int rc = azalia_program_verb_table(base, verb, verb_size); + if (rc < 0) + printk(BIOS_DEBUG, "azalia_audio: verb not loaded.\n"); + else + printk(BIOS_DEBUG, "azalia_audio: verb loaded.\n");
mainboard_azalia_program_runtime_verbs(base, reg32); }