Attention is currently required from: Ian Feng, Eric Lai, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63739 )
Change subject: mb/google/skyrim: Configure SD card reader power sequence
......................................................................
Patch Set 5:
(3 comments)
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/63739/comment/e4dd9ffc_75d70427
PS5, Line 189: /* SD_AUX_RESET_L */
: PAD_GPO(GPIO_27, LOW),
I think this pin will always get reset, so no need to add it here.
https://review.coreboot.org/c/coreboot/+/63739/comment/aa841415_843acef1
PS5, Line 201: PAD_GPO
Can you try the following: `PAD_NFO(GPIO_27, PCIE_RST1_L, HIGH),` also update it in the ramstage list.
https://review.coreboot.org/c/coreboot/+/63739/comment/b231c1e3_86a72cb7
PS5, Line 201: PAD_GPO(GPIO_27, HIGH),
Yes,remove set HIGH SD card is not working.
I suspect it's a timing issue. How long does the SD controller need after reset is de-asserted before it can be enumerated?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63739
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03d88d90acc03cdebcb1e83ed2e799dda8b5b735
Gerrit-Change-Number: 63739
Gerrit-PatchSet: 5
Gerrit-Owner: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 22 Apr 2022 15:54:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ian Feng
ian_feng@compal.corp-partner.google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment