Attention is currently required from: Nico Huber, Angel Pons, Subrata Banik, Patrick Rudolph.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51205 )
Change subject: soc/intel/skylake: Do not unhide P2SB before disabling HECI
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/skylake/finalize.c:
https://review.coreboot.org/c/coreboot/+/51205/comment/050d28bf_0cb34857
PS3, Line 37: p2sb_unhide();
Removing this call doesn't make things clearer, IMHO. […]
If P2SB is meant to remain hidden in coreboot (and only be unhidden when required), I can look into where it may be used and not hidden.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51205
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide61392992db4d1ab74e1fff500000a427a87347
Gerrit-Change-Number: 51205
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 03 Mar 2021 17:54:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment