Attention is currently required from: Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55198 )
Change subject: [RFC,WIP] cpu/x86/lapic: Evaluate x2apic_mode just once
......................................................................
Patch Set 12: Code-Review-1
(2 comments)
Patchset:
PS12:
Breaks booting with X2APIC_RUNTIME on Haswell (X2APIC_ONLY didn't work before).
File src/cpu/x86/lapic/lapic.c:
https://review.coreboot.org/c/coreboot/+/55198/comment/de1e4b2a_272840fb
PS12, Line 20: msr = rdmsr(LAPIC_BASE_MSR);
This MSR is thread-specific on Haswell (no idea about other processors).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55198
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff4f5dc50999f977eaf9b32e7caebf098a3600fe
Gerrit-Change-Number: 55198
Gerrit-PatchSet: 12
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ron Minnich
rminnich@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 13 Oct 2021 12:22:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment