Attention is currently required from: Furquan Shaikh, Martin Roth, Julius Werner.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55581 )
Change subject: util/cbfstool: Remove unused pagesize parameter
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
Alignment is not the same as what the page size parameter did. Page size just made sure that the stage doesn't cross a page boundary. Alignment forces it to begin at the start of that boundary. With alignment there's a lot higher chance that this will actually do anything (and thereby waste space on padding).
Not sure if we care enough in practice to carry the extra logic around, just wanted to point it out.
You're right and aligning is not what is desired here. I just removed the option to set the pagesize manually, since we only pow2_pagesize.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55581
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib672ba8ed418b1a76e4a48951eabda6923358e7a
Gerrit-Change-Number: 55581
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 17 Jun 2021 05:11:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment