Change in coreboot[master]: [RFC] device: Introduce new method for setting device states
Attention is currently required from: Felix Singer, Nico Huber, Raul Rangel, Furquan Shaikh, Matt DeVillier, Michael Niewöhner, Patrick Rudolph, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52493 ) Change subject: [RFC] device: Introduce new method for setting device states ...................................................................... Patch Set 17: (1 comment) File src/include/device/devenmap.h: https://review.coreboot.org/c/coreboot/+/52493/comment/a5b9ef21_15389b99 PS14, Line 12: uint8_t
you already made the pointer const ;) I meant `const uint8_t` if you make this `const uint8_t *option`, then it's a read-only pointer, i.e. a pointer to `const uint8_t`. Which will not work.
-- To view, visit https://review.coreboot.org/c/coreboot/+/52493 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70fde306c65a8881f565c5f923be20f380ea64d3 Gerrit-Change-Number: 52493 Gerrit-PatchSet: 17 Gerrit-Owner: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Felix Singer <felixsinger@posteo.net> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Raul Rangel <rrangel@chromium.org> Gerrit-Attention: Furquan Shaikh <furquan@google.com> Gerrit-Attention: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Attention: Michael Niewöhner <foss@mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro@das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-Comment-Date: Sat, 01 May 2021 10:22:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net> Comment-In-Reply-To: Michael Niewöhner <foss@mniewoehner.de> Gerrit-MessageType: comment
participants (1)
-
Angel Pons (Code Review)